Add suggestion for vue/require-name-property rule
#2034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FloEdelmann
requested changes
Nov 10, 2022
Member
FloEdelmann
left a comment
FloEdelmann
left a comment
There was a problem hiding this comment.
Thanks for the suggestion and the implementation!
Can we always auto-fix this to the filename or should we rather only add a suggestion for that, which the user can manually apply?
Also, please see the issues below.
Contributor
Author
|
ok, i think add a suggestion for that is better too, i will rewrite the code and add test case. |
Contributor
Author
|
i push new code for this feature, and add some new test case for this rule and suggestions. |
FloEdelmann
changed the title
vue/require-name-property rule
FloEdelmann
approved these changes
Nov 16, 2022
Member
FloEdelmann
left a comment
FloEdelmann
left a comment
There was a problem hiding this comment.
Looks good to me now. Thanks for the changes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a pull request for issues: #2033