Add new options for no-duplicate-attributes #112
#113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you for contributing! I'm sorry for the delay. Please see #112 (comment) |
armano2
force-pushed
the
patch-21-no-duplicate-attributes
branch
from
de7e193 to
33631a3
Compare
mysticatea
reviewed
Aug 3, 2017
Member
mysticatea
left a comment
mysticatea
left a comment
There was a problem hiding this comment.
Thank you for contributing!
Could you add a few tests?
lib/rules/no-duplicate-attributes.js
Outdated
| return directiveNames.has(name) | ||
| } | ||
| if (allowCoexistClass && name === 'class') { | ||
| return directiveNames.has(name) |
Member
There was a problem hiding this comment.
I'd like to see the test of the following case:
<div :class="a" class="b"></div>I guess that the class="b" is warned even if allowCoexistClass is true.
Contributor
Author
There was a problem hiding this comment.
@mysticatea you are completely right on this, 👍
lib/rules/no-duplicate-attributes.js
Outdated
| const names = new Set() | ||
| const options = context.options[0] || {} | ||
| const allowCoexistStyle = Boolean(options.allowCoexistStyle !== false) | ||
| const allowCoexistClass = Boolean(options.allowCoexistClass !== false) |
Member
There was a problem hiding this comment.
I think that this cast is redundant since the result of !== expression is always boolean.
Contributor
Author
|
@mysticatea changes applied and i added few more tests |
mysticatea
approved these changes
Aug 3, 2017
Member
mysticatea
left a comment
mysticatea
left a comment
There was a problem hiding this comment.
LGTM, thank you very much!
filipalacerda
pushed a commit
to filipalacerda/eslint-plugin-vue
that referenced
this pull request
Aug 5, 2017
* master: Add rule `vue/require-valid-default-prop`. (vuejs#119) 3.10.0 Update readme to 3.10.0 Chore: remove package-lock.json (vuejs#128) Fix: parserService must exist always (fixes vuejs#125) (vuejs#127) Add rule `require-render-return`. (vuejs#114) 3.9.0 Update package-lock Update: options for `no-duplicate-attributes` (fixes vuejs#112)(vuejs#113) New: add rule `attribute-hyphenation`. (fixes vuejs#92)(vuejs#95) Add namespace check of svg & mathML instead of tag names (vuejs#120)⚠️ Add support for deprecated state in update-rules⚠️ (vuejs#121) Add rules: `no-dupe-keys` and `no-reserved-keys`. (vuejs#88) Chore: Improve tests for name-property-casing & improve documentation (vuejs#115) New: add `require-prop-types` rule (fixes vuejs#19)(vuejs#85) Update: upgrade vue-eslint-parser (fixes vuejs#36, fixes vuejs#56, fixes vuejs#96) (vuejs#116)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allowCoexistClass- Enablesv-bind:classdirective can co-exist with the plainclassattribute.allowCoexistStyle- Enablesv-bind:styledirective can co-exist with the plainstyleattribute.This PR should fix bug: fixes #112 .