-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Migrate Style Guide #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Page ready for review: https://deploy-preview-56--vue-next.netlify.com/style-guide/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @phanan! I've left a question regarding examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the super quick fix @phanan 🚀
I've created a follow-up issue just to keep a fix in mind and I'm approving this PR 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Just one question. Also as mentioned by @bencodezen, we can go back in and color things well in this new version so it's super clear
@@ -0,0 +1,1872 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(new to VuePress:) why do we need the sidebar: auto
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm no VuePress master either 😅 The way I understand it, for VuePress to auto-generate a sidebar from the headings of the current page, we can either:
-
set it in the global
config.js
filemodule.exports = { themeConfig: { sidebar: 'auto' } }
-
or, set it as the YAML front-matter per Markdown file
--- sidebar: auto ---
Since we're already configured themeConfig.sidebar
to be a custom object in our config.js
(I'm not sure if it's necessary TBH), I'm going with the second option.
Closes #24.