Skip to content

Added template refs typing instruction #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 5, 2021
Merged

Added template refs typing instruction #1022

merged 3 commits into from
May 5, 2021

Conversation

NataliaTepluhina
Copy link
Member

Close #980

skirtles-code
skirtles-code reviewed Apr 29, 2021
View reviewed changes
Copy link
Contributor

@skirtles-code skirtles-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really comment on the specifics from a TS perspective but I did try running the code and it seemed to work as described.

I've made a suggestion for how we present the first example but overall this looks good to me.

skirtles-code
skirtles-code suggested changes May 1, 2021
View reviewed changes
@skirtles-code skirtles-code merged commit d5c6635 into master May 5, 2021
@skirtles-code skirtles-code deleted the template-refs-type branch May 5, 2021 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skirtles-code skirtles-code Awaiting requested review from skirtles-code

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document template ref typing in TS (i.e. InstanceType)
2 participants
@NataliaTepluhina @skirtles-code