Skip to content

Conversation

@btea
Copy link
Collaborator

@btea btea commented Feb 21, 2024

No description provided.

Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, but maybe the proper fix is to use the parameter to generate the readme?

@btea
Copy link
Collaborator Author

btea commented Feb 21, 2024

Makes sense, but I'm not sure what the generated content based on the needsNightwatchCT parameter should be?

@cexbrayat
Copy link
Member

I think needsNightwatch is used twice, instead I think it should be needsNightwatchCT here https://github.com/vuejs/create-vue/pull/448/files#diff-a4daf76507373a095f626fff68f5cecaa33d5d10a4dbca6aaad95ef30a80bd30R125

@btea btea force-pushed the chore/remove-unused-parameter branch from cf9dc45 to 25907ae Compare February 21, 2024 09:37
@btea
Copy link
Collaborator Author

btea commented Feb 21, 2024

Okay, I have made the modifications.

@cexbrayat cexbrayat merged commit 32a0aa6 into vuejs:main Feb 21, 2024
@btea btea deleted the chore/remove-unused-parameter branch February 21, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants