refactor: minimist to parseargs #443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cexbrayat
approved these changes
Feb 6, 2024
Member
cexbrayat
left a comment
cexbrayat
left a comment
There was a problem hiding this comment.
LGTM, but I'll let @sodatea decides if he wants this or not.
Note: parseArgs was added in v16.17 and v18.3, but is experimental until v20 (https://nodejs.org/api/util.html#utilparseargsconfig)
haoqunjiang
approved these changes
Feb 20, 2024
Member
haoqunjiang
left a comment
haoqunjiang
left a comment
There was a problem hiding this comment.
Thanks for the PR! It's really helpful.
Considering the parseArgs API is already stable in Node.js v20, I think it's safe to assume no breaking changes would ship to v18.x, so let's use it.
haoqunjiang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Related Issue
re #168
Checklist
Notes for Reviewers
short {string}A single character alias for the option, but it's not matching our case.