Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(apiWatch): use relative import location instead of package #9941

Merged
merged 1 commit into from
Dec 30, 2023
Merged

chore(apiWatch): use relative import location instead of package #9941

merged 1 commit into from
Dec 30, 2023

Conversation

pikax
Copy link
Member

@pikax pikax commented Dec 29, 2023

Not sure why this import is @vue/runtime-core, it should be imported relatively, unless there's a specific reason for this, if there is, it should have a comment

@pikax pikax added the 🧹 p1-chore Priority 1: this doesn't change code behavior. label Dec 29, 2023
@github-actions GitHub Actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 89.3 kB 34 kB (-7 B) 30.7 kB (+22 B)
vue.global.prod.js 146 kB 53.2 kB (+15 B) 47.5 kB (-22 B)

Usages

Name Size Gzip Brotli
createApp 49.7 kB 19.5 kB (-4 B) 17.8 kB (-5 B)
createSSRApp 53 kB 20.8 kB (-1 B) 18.9 kB (-10 B)
defineCustomElement 52 kB 20.2 kB (-5 B) 18.5 kB (+15 B)
overall 63.2 kB 24.4 kB (-3 B) 22.2 kB (-30 B)

@yyx990803 yyx990803 merged commit 4c20f50 into main Dec 30, 2023
15 checks passed
@yyx990803 yyx990803 deleted the pikax/chore_change_import branch December 30, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pikax @yyx990803