refactor(reactivity): don't convert Set into array#8718
Closed
Alfred-Skyblue wants to merge 5 commits into
Closed
Conversation
Member
|
/ecosystem-ci run |
Contributor
|
📝 Ran ecosystem CI: Open
|
sxzz
changed the title
Contributor
Comment on lines
-397
to
-398
| // spread into array for stabilization | ||
| const effects = isArray(dep) ? dep : [...dep] |
Contributor
There was a problem hiding this comment.
I believe the reason for copying the dep into an array is to ensure that the subsequent iterations are stable. The calls to triggerEffect() inside those loops could modify dep while we're trying to iterate over it.
The PR description and linked issue don't seem to mention this, so I'm wondering whether there's been a misunderstanding about the purpose of the array?
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #8714