Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-sfc): support resolve enum member for defineEmits #8475

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

edison1105
Copy link
Member

close #8466

@edison1105 edison1105 marked this pull request as draft June 1, 2023 13:29
@edison1105 edison1105 changed the title fix(compiler-sfc): support resolve enum value for defineEmits fix(compiler-sfc): support resolve enum member for defineEmits Jun 3, 2023
@edison1105 edison1105 marked this pull request as ready for review June 3, 2023 04:02
@hymair
Copy link

hymair commented Jul 27, 2023

Will this be merged soon?

@cowabonga
Copy link

@edison1105 , i need this. please merge ASAP. thanks.

@github-actions
Copy link

github-actions bot commented Oct 20, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB 38.1 kB 34.2 kB
vue.global.prod.js 160 kB 58 kB 51.5 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 49.1 kB 18.9 kB 17.3 kB
createApp 55.7 kB 21.4 kB 19.6 kB
createSSRApp 59.7 kB 23.1 kB 21 kB
defineCustomElement 60.4 kB 23 kB 20.9 kB
overall 69.4 kB 26.5 kB 24.1 kB

Copy link

pkg-pr-new bot commented Oct 10, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@8475

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@8475

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@8475

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@8475

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@8475

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@8475

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@8475

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@8475

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@8475

vue

pnpm add https://pkg.pr.new/vue@8475

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@8475

commit: 60f79ea

@edison1105 edison1105 added scope: sfc 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready for review This PR requires more reviews labels Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready for review This PR requires more reviews scope: sfc
Projects
Status: Needs Review
Development

Successfully merging this pull request may close these issues.

Vue 3.3.4. doesn't setup events defined with enum values
5 participants