-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compile-sfc): remove optional check #5958
Conversation
👷 Deploy request for vuejs-coverage pending review.Visit the deploys page to approve it
|
👷 Deploy request for vue-next-template-explorer pending review.Visit the deploys page to approve it
|
👷 Deploy request for vue-sfc-playground pending review.Visit the deploys page to approve it
|
Starting with Related commit build: output es2020 (target node 14+) for cjs/server builds. |
Already checking here https://github.com/vuejs/core/blob/main/packages/compiler-sfc/src/rewriteDefault.ts#L54 |
You are right, it is not necessary. |
fixed via cf55480 |
@yyx990803 This PR is not intended to fix the problem that Nodejs12 cannot run, but to remove unnecessary optional check. |
The optional chaining is unnecessary, but the intention was to fix the syntax in Node 12. This can be merged as a refactor/chore but not a fix. |
npx depcheck was failing with latest version