Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): fix event listener as dynamicProp is added erroneously to props #5517

Merged
merged 2 commits into from
Apr 12, 2022
Merged

fix(runtime-core): fix event listener as dynamicProp is added erroneously to props #5517

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04aa312
fix(runtime-core): fix event listener is added erroneously to instanc…
iwusong Mar 4, 2022
2b896fe
Update componentProps.ts
yyx990803 Apr 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(runtime-core): fix event listener is added erroneously to instanc… 
…e's props

fix #5520
  • Loading branch information
@iwusong
iwusong committed Mar 4, 2022
commit 04aa3122d3f00d73953943f3db04137613c8c1b4
5 changes: 5 additions & 0 deletions packages/runtime-core/src/componentProps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,11 @@ export function updateProps(
const propsToUpdate = instance.vnode.dynamicProps!
for (let i = 0; i < propsToUpdate.length; i++) {
let key = propsToUpdate[i]
// if the prop key is a declared emit event listener.
// use continue to skip this prop
if (isEmitListener(instance.emitsOptions, key)){
continue
}
// PROPS flag guarantees rawProps to be non-null
const value = rawProps![key]
if (options) {
Expand Down