Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Teleport): should always remove its children if its descendant nodes have a teleport that not disabled #4742

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

edison1105
Copy link
Member

fix #4737

@edison1105 edison1105 changed the title fix(Teleport): should always remove its children when unmount an teleport fix(Teleport): should always remove its children if its descendant nodes have a teleport that not disabled Oct 7, 2021
@github-actions
Copy link

github-actions bot commented Oct 20, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 99.2 kB (+142 B) 37.6 kB (+53 B) 33.8 kB (+2 B)
vue.global.prod.js 157 kB (+142 B) 57.4 kB (+48 B) 51 kB (-59 B)

Usages

Name Size Gzip Brotli
createApp 54.5 kB 21.1 kB 19.3 kB
createSSRApp 58.4 kB 22.8 kB 20.8 kB
defineCustomElement 59.1 kB 22.6 kB 20.6 kB
overall 68.1 kB 26.2 kB 23.8 kB

Copy link

pkg-pr-new bot commented Aug 21, 2024

commit: 53c0e21

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@4742

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@4742

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@4742

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@4742

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@4742

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@4742

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@4742

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@4742

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@4742

vue

pnpm add https://pkg.pr.new/vue@4742

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@4742

Open in Stackblitz

@edison1105 edison1105 added ready for review This PR requires more reviews 🐞 bug Something isn't working labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working ready for review This PR requires more reviews scope: teleport
Projects
Status: Needs Review
Development

Successfully merging this pull request may close these issues.

Nested Teleport of disabled teleport stays in DOM when parent is unmounted
3 participants