perf(scheduler): remove unnecessary statement currentPreParentJob #4384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code for the scheduler has undergone some significant changes since this PR was opened. From what I can tell, the most important parts of this PR apply to code that no longer exists. @gdh51 Do you think this can be closed now? Or is there some part of it that is still relevant to the current version of the scheduler? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currentPreParentJobadded in #1777,it aims to resolve the duplicate render by pre-flush watchers.But in v3.2.0 the example of #1777, it still render twice when propvaluechange.(because in functiontriggerEffect(), it'll be added into queue by effect.allowRecurse)Later in v3.2.4, this issue fixed by set
allowRecursetofalsebefore functionupdateComponentPreRender().So it's time to delete it.