Skip to content

perf(reactivity): optimize the performance of the canObserve #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 18, 2019
+7 −2
Merged

perf(reactivity): optimize the performance of the canObserve #330

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3e89eb5
perf(reactivity): optimize the performance of the `canObserve`
edison1105 Oct 18, 2019
dac96d1
perf(reactivity): optimize the performance of the `canObserve`
edison1105 Oct 18, 2019
91ea4db
perf(reactivity): use `makeMap` instead of `Set`
edison1105 Oct 18, 2019
728970e
Update reactive.ts
yyx990803 Oct 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/reactivity/src/reactive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
} from './collectionHandlers'
import { ReactiveEffect } from './effect'
import { UnwrapRef, Ref } from './ref'
import { makeMap } from '@vue/shared'

// The main WeakMap that stores {target -> key -> dep} connections.
// Conceptually, it's easier to think of a dependency as a Dep class
Expand All @@ -27,13 +28,17 @@ const readonlyValues = new WeakSet<any>()
const nonReactiveValues = new WeakSet<any>()

const collectionTypes = new Set<Function>([Set, Map, WeakMap, WeakSet])
const observableValueRE = /^\[object (?:Object|Array|Map|Set|WeakMap|WeakSet)\]$/
const isObservableType = /*#__PURE__*/ makeMap(
['Object', 'Array', 'Map', 'Set', 'WeakMap', 'WeakSet']
.map(t => `[object ${t}]`)
.join(',')
)

const canObserve = (value: any): boolean => {
return (
!value._isVue &&
!value._isVNode &&
observableValueRE.test(toTypeString(value)) &&
isObservableType(toTypeString(value)) &&
!nonReactiveValues.has(value)
)
}
Expand Down