Skip to content

chore(playground): disable unsupported ts7 and eliminate vite warn - #15241

Merged
edison1105 merged 3 commits into
vuejs:mainfrom
btea:fix/sfc-vite-warn-and-unsupported-ts-7
Aug 10, 2026
Merged

edison1105 merged 3 commits into
vuejs:mainfrom
btea:fix/sfc-vite-warn-and-unsupported-ts-7

Conversation

@btea

@btea btea commented Aug 9, 2026 •

Copy link
Copy Markdown
Contributor

refs vitejs/vite#22850

TypeScript 7 does not support Vue, and the path is incorrect after switching to TypeScript 7, so TypeScript 7 is temporarily disabled. Alternatively, we can migrate to https://github.com/johnsoncodehk/typescript-native-bridge later.

Summary by CodeRabbit

  • New Features
    • TypeScript 7.x versions are now clearly marked as unavailable in the version selector.
    • Unavailable versions appear disabled, use a not-allowed cursor, and cannot be selected.
    • Version selection remains available for supported TypeScript releases.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026 •

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The SFC playground disables TypeScript 7.x options and styles them as unavailable. The Vite copy plugin now resolves package files from import.meta.dirname.

Changes

SFC Playground updates

Layer / File(s) Summary
Disable TypeScript 7.x selections
packages-private/sfc-playground/src/VersionSelect.vue
TypeScript versions beginning with 7. are disabled. Disabled links use muted styling, a not-allowed cursor, and disabled pointer events.
Update Vite path resolution
packages-private/sfc-playground/vite.config.ts
copyVuePlugin uses import.meta.dirname instead of __dirname while preserving the existing path resolution behavior.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes both main changes: disabling unsupported TypeScript 7 options and eliminating the Vite warning.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 108 kB 40.7 kB 36.5 kB
vue.global.prod.js 167 kB 60.9 kB 54.2 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 49.7 kB 19.3 kB 17.7 kB
createApp 57.8 kB 22.3 kB 20.4 kB
createSSRApp 62.5 kB 24.3 kB 22.1 kB
defineCustomElement 64.1 kB 24.3 kB 22.1 kB
overall 72.1 kB 27.5 kB 25.1 kB

@pkg-pr-new

pkg-pr-new Bot commented Aug 9, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@15241
npm i https://pkg.pr.new/@vue/compiler-core@15241
yarn add https://pkg.pr.new/@vue/compiler-core@15241.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@15241
npm i https://pkg.pr.new/@vue/compiler-dom@15241
yarn add https://pkg.pr.new/@vue/compiler-dom@15241.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@15241
npm i https://pkg.pr.new/@vue/compiler-sfc@15241
yarn add https://pkg.pr.new/@vue/compiler-sfc@15241.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@15241
npm i https://pkg.pr.new/@vue/compiler-ssr@15241
yarn add https://pkg.pr.new/@vue/compiler-ssr@15241.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@15241
npm i https://pkg.pr.new/@vue/reactivity@15241
yarn add https://pkg.pr.new/@vue/reactivity@15241.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@15241
npm i https://pkg.pr.new/@vue/runtime-core@15241
yarn add https://pkg.pr.new/@vue/runtime-core@15241.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@15241
npm i https://pkg.pr.new/@vue/runtime-dom@15241
yarn add https://pkg.pr.new/@vue/runtime-dom@15241.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@15241
npm i https://pkg.pr.new/@vue/server-renderer@15241
yarn add https://pkg.pr.new/@vue/server-renderer@15241.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@15241
npm i https://pkg.pr.new/@vue/shared@15241
yarn add https://pkg.pr.new/@vue/shared@15241.tgz

vue

pnpm add https://pkg.pr.new/vue@15241
npm i https://pkg.pr.new/vue@15241
yarn add https://pkg.pr.new/vue@15241.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@15241
npm i https://pkg.pr.new/@vue/compat@15241
yarn add https://pkg.pr.new/@vue/compat@15241.tgz

commit: 832418d

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages-private/sfc-playground/src/VersionSelect.vue`:
- Around line 146-151: Update the disabled version styling around the .versions
disabled anchor so the not-allowed cursor is applied to the element receiving
pointer hit testing; use a suitable wrapper or retain anchor pointer events and
guard setVersion against TypeScript 7.x, while preserving disabled click
prevention.
- Line 94: Validate every incoming typescriptVersion value before assigning it
to store.typescriptVersion, not only through the disabled list option in
VersionSelect. Reject versions beginning with “7.” when values arrive via
defineModel(), App.vue’s prop, or restored serializer state, while preserving
valid version assignments.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 30539652-5850-4240-a052-278bc91f331b

📥 Commits

Reviewing files that changed from the base of the PR and between 8f89be8 and 99eb27f.

📒 Files selected for processing (2)
  • packages-private/sfc-playground/src/VersionSelect.vue
  • packages-private/sfc-playground/vite.config.ts

Comment thread packages-private/sfc-playground/src/VersionSelect.vue Outdated
Comment thread packages-private/sfc-playground/src/VersionSelect.vue Outdated
@edison1105 edison1105 changed the title fix(sfc): disable unsupported ts7 and eliminate vite warn chore(playground): disable unsupported ts7 and eliminate vite warn Aug 10, 2026
@edison1105
edison1105 merged commit b527b64 into vuejs:main Aug 10, 2026
14 checks passed
@btea
btea deleted the fix/sfc-vite-warn-and-unsupported-ts-7 branch August 10, 2026 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants