Repository navigation
chore(playground): disable unsupported ts7 and eliminate vite warn - #15241
Merged
edison1105 merged 3 commits intoAug 10, 2026
Merged
Conversation
📝 WalkthroughWalkthroughThe SFC playground disables TypeScript 7.x options and styles them as unavailable. The Vite copy plugin now resolves package files from ChangesSFC Playground updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages-private/sfc-playground/src/VersionSelect.vue`:
- Around line 146-151: Update the disabled version styling around the .versions
disabled anchor so the not-allowed cursor is applied to the element receiving
pointer hit testing; use a suitable wrapper or retain anchor pointer events and
guard setVersion against TypeScript 7.x, while preserving disabled click
prevention.
- Line 94: Validate every incoming typescriptVersion value before assigning it
to store.typescriptVersion, not only through the disabled list option in
VersionSelect. Reject versions beginning with “7.” when values arrive via
defineModel(), App.vue’s prop, or restored serializer state, while preserving
valid version assignments.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 30539652-5850-4240-a052-278bc91f331b
📒 Files selected for processing (2)
packages-private/sfc-playground/src/VersionSelect.vuepackages-private/sfc-playground/vite.config.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs vitejs/vite#22850
TypeScript 7 does not support Vue, and the path is incorrect after switching to TypeScript 7, so TypeScript 7 is temporarily disabled. Alternatively, we can migrate to https://github.com/johnsoncodehk/typescript-native-bridge later.
Summary by CodeRabbit