Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(runtime-core): provide valid type for default $emit #1498

Merged
merged 4 commits into from
Jul 8, 2020

Conversation

pikax
Copy link
Member

@pikax pikax commented Jul 3, 2020

relates to vuejs/test-utils#144

When using ComponentPublicApi the emit type defaults to an empty object, making the $emit to be unknown type instead of the default emit function (event: string, ...args: any[]) => void

@haoqunjiang
Copy link
Member

This change seems to have broken vue-class-component.
Cc: @ktsn

@pikax
Copy link
Member Author

pikax commented Jul 15, 2020

@sodatea Thank you :)

There's the fix: #1584

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants