feat(types): add new HTML attributes for improved JSX support #13370

jeffwcx · 2025-05-22T04:13:17Z

Move enterKeyHint, exportparts, and part attributes to HTMLAttributes.
According to [@types/react-dom] enterKeyHint not defined on most elements DefinitelyTyped/DefinitelyTyped#70409
Added fetchpriority attribute to ImgHTMLAttributes.
Updated IntrinsicElementAttributes to include set element support.

Summary by CodeRabbit

New Features
- Added support for the enterKeyHint attribute on more HTML elements.
- Introduced support for the global HTML attributes exportparts and part.
- Added support for the fetchpriority attribute on image elements.
- Enabled use of the SVG set element.

- Move `enterKeyHint`, `exportparts`, and `part` attributes to `HTMLAttributes`. - Added `fetchpriority` attribute to `ImgHTMLAttributes`. - Updated `IntrinsicElementAttributes` to include `set` element support.

coderabbitai · 2025-05-22T04:13:24Z

Walkthrough

The code update expands and refines TypeScript JSX attribute typings. It introduces new global HTML attributes, consolidates the definition of the enterKeyHint attribute, adds support for the fetchpriority attribute on images, and includes the SVG set element in the intrinsic element attributes.

Changes

File(s)	Change Summary
packages/runtime-dom/src/jsx.ts	- Added `enterKeyHint` to `HTMLAttributes` and removed it from `InputHTMLAttributes`. - Added `exportparts` and `part` to `HTMLAttributes`. - Added `fetchpriority` to `ImgHTMLAttributes`. - Added `set` with `SVGAttributes` to `IntrinsicElementAttributes`.

Poem

In the garden of tags, new seeds are sown,
enterKeyHint now stands on its own.
exportparts and part join the HTML crew,
While images fetch with priorities new.
The SVG set hops into the mix—
Typings refined with a few clever tricks!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6329146 and ce753e2.

📒 Files selected for processing (1)

packages/runtime-dom/src/jsx.ts (4 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/runtime-dom/src/jsx.ts

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: Redirect rules
GitHub Check: Header rules
GitHub Check: Pages changed

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

jeffwcx · 2025-05-22T04:21:17Z

@johnsoncodehk @sxzz

github-actions · 2025-05-22T08:37:43Z

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	101 kB	38.3 kB	34.5 kB
vue.global.prod.js	159 kB	58.5 kB	52 kB

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	46.6 kB	18.2 kB	16.7 kB
createApp	54.5 kB	21.2 kB	19.4 kB
createSSRApp	58.8 kB	23 kB	20.9 kB
defineCustomElement	59.5 kB	22.8 kB	20.8 kB
overall	68.6 kB	26.4 kB	24.1 kB

pkg-pr-new · 2025-05-22T08:37:49Z

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13370

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13370

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13370

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13370

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13370

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13370

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13370

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13370

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13370

vue

npm i https://pkg.pr.new/vue@13370

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13370

commit: 6329146

packages/runtime-dom/src/jsx.ts

…utes

feat(types): add new HTML attributes for improved JSX support

6329146

- Move `enterKeyHint`, `exportparts`, and `part` attributes to `HTMLAttributes`. - Added `fetchpriority` attribute to `ImgHTMLAttributes`. - Updated `IntrinsicElementAttributes` to include `set` element support.

vercel bot deployed to Preview May 22, 2025 04:14 View deployment

KazariEX added scope: types 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. labels May 22, 2025

edison1105 added the ready to merge The PR is ready to be merged. label May 22, 2025

skirtles-code reviewed Jun 3, 2025

View reviewed changes

packages/runtime-dom/src/jsx.ts Outdated Show resolved Hide resolved

fix: correct casing of enterKeyHint to enterkeyhint in HTMLAttrib…

ce753e2

…utes

vercel bot deployed to Preview June 5, 2025 15:44 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(types): add new HTML attributes for improved JSX support #13370

feat(types): add new HTML attributes for improved JSX support #13370

jeffwcx commented May 22, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented May 22, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

jeffwcx commented May 22, 2025

Uh oh!

github-actions bot commented May 22, 2025

Uh oh!

pkg-pr-new bot commented May 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

feat(types): add new HTML attributes for improved JSX support #13370

Are you sure you want to change the base?

feat(types): add new HTML attributes for improved JSX support #13370

Conversation

jeffwcx commented May 22, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

jeffwcx commented May 22, 2025

Uh oh!

github-actions bot commented May 22, 2025

Size Report

Bundles

Usages

Uh oh!

pkg-pr-new bot commented May 22, 2025

Uh oh!

Uh oh!

Uh oh!

jeffwcx commented May 22, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 22, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)