Skip to content

fix(compat): ensure false value on input value retains attribute #13216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025
Merged

fix(compat): ensure false value on input value retains attribute #13216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50795f7
fix(compat): ensure false value on input retains value attribute
edison1105 Apr 17, 2025
6196ff6
Merge branch 'main' into edison/fix/13205
edison1105 May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/runtime-dom/src/modules/attrs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ export function compatCoerceAttr(
}
} else if (
value === false &&
!(el.tagName === 'INPUT' && key === 'value') &&
!isSpecialBooleanAttr(key) &&
compatUtils.isCompatEnabled(DeprecationTypes.ATTR_FALSE_VALUE, instance)
) {
Expand Down
14 changes: 14 additions & 0 deletions packages/vue-compat/__tests__/misc.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,20 @@ test('ATTR_FALSE_VALUE', () => {
).toHaveBeenWarned()
})

test('ATTR_FALSE_VALUE with false on input value', () => {
const vm = new Vue({
template: `<input :value="false"/>`,
}).$mount()
expect(vm.$el).toBeInstanceOf(HTMLInputElement)
expect(vm.$el.hasAttribute('value')).toBe(true)
expect(vm.$el.getAttribute('value')).toBe('false')
expect(
(deprecationData[DeprecationTypes.ATTR_FALSE_VALUE].message as Function)(
'value',
),
).not.toHaveBeenWarned()
})

test("ATTR_FALSE_VALUE with false value shouldn't throw warning", () => {
const vm = new Vue({
template: `<div :id="false" :foo="false"/>`,
Expand Down