-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
feat(vapor): vapor transition + transition-group #12962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for vapor-repl ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/compiler-vapor
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
47e4e13 to
71db1e0
Compare
71db1e0 to
41822e3
Compare
a6362cb to
989e79f
Compare
989e79f to
1e79054
Compare
93a4de3 to
f139002
Compare
f139002 to
841e0cf
Compare
841e0cf to
11bcb21
Compare
1b5e9ef to
27d15c5
Compare
27d15c5 to
3fcba1d
Compare
44be78b to
afc732e
Compare
3048952 to
9ee219a
Compare
d486cf8 to
2caeecd
Compare
4c016a8 to
e42ff1b
Compare
d6861d4 to
cb8830f
Compare
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
41aba70 to
542e401
Compare
Size ReportBundles
Usages
|
Compiler Changes
Transitionis automatically rewritten asVaporTransitionTransitionGroupis automatically rewritten asVaporTransitionGroupTransitionuses thev-if, the compiler automatically adds a$keyproperty to the rendering result, making it easier for the runtime to track the element's leaving state using thekeywill be compiled to
Transitionhas an explicitkey, the compiler generates code that includescreateKeyedFragment, which creates a newDynamicFragmentwhen thekeychanges, triggering transitionswill be compiled to
appearis set in theTransitionand the root node usesv-show, it need to executeapplyVShowafter theTransitionis created to ensure that the appear behavior works properly.will be compiled to
Runtime Changes
VaporTransitionandVaporTransitionGroupcomponents that reuses most of the logic fromruntime-dom/TransitionTransitionhooks are now stored on theblock.$transitionpropertyDynamicFragmentUpdate Logic Modification:baseResolveTransitionHooksfrom the existingresolveTransitionHooksfunction to be shared betweenVaporTransitionandTransition. Each component passes its own specificTransitionHooksContextTransitioncomponent now supports renderingVaporcomponentsTests