fix(custom-element): preserve appContext during hmr reload #12455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-ssr
@vue/compiler-sfc
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
edison1105
changed the title
edison1105
added
🔨 p3-minor-bug
edison1105
changed the title
edison1105
commented
Nov 22, 2024
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (1)
packages/runtime-dom/src/apiCustomElement.ts:524
- The new behavior introduced in the '_update' method should be covered by tests to ensure that 'vnode.appContext' is correctly set.
if (this._app && !this._instance) vnode.appContext = this._app._context
|
@edison1105 Can you tell me when this will be merged? Some colleagues and me would be very happy if the HMR works again for us 😅 |
|
@danieldasilva-smake npm i https://pkg.pr.new/vue@12455It includes the latest code from the main branch. |
|
""" WalkthroughA new test case was added to verify that the provide context and global properties configured via Changes
Sequence Diagram(s)sequenceDiagram
participant TestRunner
participant CustomElement
participant VueApp
participant VNode
participant HMRRuntime
TestRunner->>CustomElement: Mount custom element with configureApp
CustomElement->>VueApp: Provide context and set global properties
CustomElement->>VNode: Create VNode and assign appContext
CustomElement->>VueApp: Render VNode
TestRunner->>HMRRuntime: Trigger HMR reload
HMRRuntime->>CustomElement: Reload component definition
CustomElement->>VNode: Create new VNode and assign appContext
CustomElement->>VueApp: Render new VNode
TestRunner->>CustomElement: Verify context and globals persist
Assessment against linked issues
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
edison1105
commented
May 14, 2025
| @@ -520,7 +520,9 @@ export class VueElement | |||
| } | |||
|
|
|||
| private _update() { | |||
| render(this._createVNode(), this._root) | |||
| const vnode = this._createVNode() | |||
| if (this._app) vnode.appContext = this._app._context | |||
There was a problem hiding this comment.
Whether it's an HMR update or not, the appContext needs to be preserved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #12453
Summary by CodeRabbit
Bug Fixes
Tests