Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): use feature flag for call to resolveMergedOptions #12163

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

skirtles-code
Copy link
Contributor

Not sure whether this counts as fix, perf or refactor. Feel free to adjust accordingly.

I was doing some analysis of bundle size across Vue versions and noticed a jump in 3.2.39. This seems to have been caused by #6250. We didn't have size checks on PRs back then, and I don't see it discussed on the PR, so I assume this just slipped through.

It only impacts projects using __VUE_OPTIONS_API__: false.

The call to resolveMergedOptions prevents a big chunk of the Options API from being treeshaken. It's used to resolve template from extends and mixins, but I believe that is only relevant when __FEATURE_OPTIONS_API__ is true.

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 38 kB 34.2 kB
vue.global.prod.js 159 kB 57.9 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.9 kB (-1.45 kB) 18.3 kB (-477 B) 16.7 kB (-485 B)
createApp 55 kB 21.3 kB 19.4 kB
createSSRApp 59 kB 23 kB 20.9 kB
defineCustomElement 59.8 kB 22.8 kB 20.8 kB
overall 68.7 kB 26.3 kB 24 kB

Copy link

pkg-pr-new bot commented Oct 13, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12163

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12163

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12163

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12163

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12163

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12163

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12163

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12163

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12163

vue

pnpm add https://pkg.pr.new/vue@12163

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12163

commit: 4d66a03

@yyx990803 yyx990803 merged commit 1755ac0 into vuejs:main Oct 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants