Skip to content

fix(types): update examples in JSDoc for augmenting global properties and custom options #11609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

romansp
Copy link
Contributor

@romansp romansp commented Aug 14, 2024

Update JSDoc examples for augmentation to be consistent with the examples in the docs https://vuejs.org/guide/typescript/options-api.html#augmenting-global-properties.

Fixes #11605.

@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🧹 p1-chore Priority 1: this doesn't change code behavior. easy to merge labels Aug 14, 2024
@yyx990803 yyx990803 merged commit c96ec67 into vuejs:main Aug 14, 2024
5 checks passed
@romansp romansp deleted the fix/11605-jsdoc-augmenting-properties-options branch August 14, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior. easy to merge ready to merge The PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSDoc examples for augmenting global properties and custom options differ from docs
3 participants