Skip to content

Conversation

@kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Aug 5, 2024

What

I cherry-picked changes on #11431 and added test for this issue on top of the existing test case by adding extra conditions.
(Should I add test case separately for this?)

Fix #11427
Close #11431

@edison1105 edison1105 added scope: keep-alive 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready for review This PR requires more reviews labels Aug 5, 2024
@netlify
Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for vue-next-template-explorer failed.

Name Link
🔨 Latest commit f8ef733
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/66b24f7496f4fc0009676685

@kakkokari-gtyih
Copy link
Contributor Author

#11496 (comment) seems nothing to do with the content of the PR

@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented Aug 6, 2024

Netlify keeps failing... Are there other PRs affected?

@github-actions
Copy link

github-actions bot commented Aug 7, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.1 kB (+4 B) 34.6 kB (+2 B) 31.1 kB (+4 B)
vue.global.prod.js 147 kB (+4 B) 54 kB (+2 B) 48 kB (-23 B)

Usages

Name Size Gzip Brotli
createApp 49.6 kB 19.5 kB 17.8 kB
createSSRApp 53.2 kB 21 kB 19.1 kB
defineCustomElement 51.9 kB 20.2 kB 18.5 kB
overall 63.1 kB (+4 B) 24.5 kB (+3 B) 22.3 kB (-30 B)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready for review This PR requires more reviews scope: keep-alive

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When the number of unresolved async component caches exceeds max set to KeepAlive, nothing is rendered

4 participants