Skip to content

fix(runtime-core): no emit triggered when the same value is set using defineModel #11162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2024
Merged

fix(runtime-core): no emit triggered when the same value is set using defineModel #11162

merged 2 commits into from
Jul 17, 2024

Conversation

@yangxiuxiu1115
Copy link
Contributor

@yangxiuxiu1115 yangxiuxiu1115 commented Jun 17, 2024 •
edited
Loading

fix #11125

@github-actions
Copy link

github-actions bot commented Jul 17, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90 kB (+7 B) 34.5 kB (+1 B) 31.1 kB (+27 B)
vue.global.prod.js 147 kB (+7 B) 54 kB (+1 B) 48 kB (+12 B)

Usages

Name Size Gzip Brotli
createApp 49.8 kB 19.5 kB 17.8 kB
createSSRApp 53.3 kB 21 kB 19.1 kB
defineCustomElement 52.1 kB 20.3 kB 18.5 kB
overall 63.3 kB 24.5 kB 22.3 kB

@yyx990803 yyx990803 merged commit f1bb0ae into vuejs:main Jul 17, 2024
@yangxiuxiu1115 yangxiuxiu1115 deleted the fix/defineModel branch July 17, 2024 08:47
@edison1105 edison1105 mentioned this pull request Aug 7, 2024
Closed
@edison1105 edison1105 mentioned this pull request Dec 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

defineModel is triggering update event, even if its value didn't actually change

2 participants

@yangxiuxiu1115 @yyx990803