Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(script): an error is reported if package.json does not exist #10016

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

liuseen-l
Copy link
Contributor

Some packages do not have a package.json, so an error will be reported when you run build-all-cjs
image

Copy link

github-actions bot commented Jan 6, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 89.4 kB 34 kB 30.7 kB
vue.global.prod.js 146 kB 53.3 kB 47.6 kB

Usages

Name Size Gzip Brotli
createApp 49.7 kB 19.5 kB 17.8 kB
createSSRApp 53.1 kB 20.8 kB 19 kB
defineCustomElement 52 kB 20.2 kB 18.5 kB
overall 63.2 kB 24.4 kB 22.2 kB

@liuseen-l liuseen-l changed the title fix(script): An error is reported if package.json does not exist fix(script): an error is reported if package.json does not exist Jan 6, 2024
@skirtles-code
Copy link
Contributor

The underlying problem here is similar to #9968. The reactivity-transform package has been removed, but it may still be present on your system because it contains uncommitted files (e.g. the output from an old build).

I've encountered this myself a few times when moving back and forth between branches. To fix it you just need to delete the reactivity-transform folder. I'm unclear whether this is a common enough problem to justify trying to fix it, but I suspect any 'fix' would just be a warning to tell people to delete that folder.

@yyx990803
Copy link
Member

yyx990803 commented Jan 9, 2024

This is a nice to have since the lingering folder isn't checked in the branches that don't have it, so ignoring it saves the trouble. (we may have such packages in the future)

@yyx990803 yyx990803 merged commit 3135fcb into vuejs:main Jan 9, 2024
11 checks passed
@liuseen-l liuseen-l deleted the fix/script branch August 2, 2024 09:34
@liuseen-l liuseen-l restored the fix/script branch August 2, 2024 09:35
@liuseen-l liuseen-l deleted the fix/script branch August 2, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants