Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

literal constant references should be supported in macros #5750

Closed
sxzz opened this issue Apr 19, 2022 · 1 comment · Fixed by #5752
Closed

literal constant references should be supported in macros #5750

sxzz opened this issue Apr 19, 2022 · 1 comment · Fixed by #5752
Labels
scope: script-setup ✨ feature request New feature or request

Comments

@sxzz
Copy link
Member

sxzz commented Apr 19, 2022 •
edited
Loading

What problem does this feature solve?

Consider the following code

<script setup>
const UPDATE_KEY = "foo"
defineEmits([UPDATE_KEY])
</script>

UPDATE_KEY will never be changed and uses no lifecycle hooks.
It can be hoisted, then defineProps and defineEmits can reference this variable.

What does the proposed API look like?

No API involved
@sxzz sxzz mentioned this issue Apr 19, 2022
Merged
@sxzz
Copy link
Member Author

sxzz commented Apr 19, 2022 •
edited
Loading

There's a demo.
https://deploy-preview-5752--vue-sfc-playground.netlify.app/#eyJBcHAudnVlIjoiPHNjcmlwdCBzZXR1cCBsYW5nPVwidHNcIj5cbmltcG9ydCB7IGdldEN1cnJlbnRJbnN0YW5jZSB9IGZyb20gJ3Z1ZSdcbmNvbnN0IGEgPSAnZm9vJyxcbiAgYTIgPSAnYmFyJ1xuY29uc3QgYTMgPSAnYmF6J1xuY29uc3QgYTQgPSBbJ3F1eCddXG5jb25zdCBhNSA9ICgnZnJlZCcsICd0aHVkJyk7XG5lbnVtIGE2IHtcbiAgRm9vID0gXCJmb29cIixcbiAgQmFyID0gXCJiYXJcIlxufVxuY29uc3QgYiA9IGNsYXNzIHt9XG5jb25zdCBjID0gW0Jvb2xlYW5dXG5jb25zdCBkID0gQm9vbGVhblxuY29uc3QgZSA9IGdldEN1cnJlbnRJbnN0YW5jZSgpXG5jb25zdCBmID0gW2dldEN1cnJlbnRJbnN0YW5jZSgpXVxubGV0IGcgPSAxXG52YXIgaCA9IDFcbmNvbnN0IGkgPSAoZysrLCAndGh1ZCcpXG5lbnVtIGoge1xuICBGT08gPSAxLFxuICBCQVIgPSBnZXRDdXJyZW50SW5zdGFuY2UoKSxcbn1cbiAgXG5kZWZpbmVFbWl0cyhbYSwgYTIsIGEzLCBhNFswXSwgYTUsIGE2LkZvb10pXG5kZWZpbmVQcm9wcyh7XG4gIGE6e1xuICAgIGRlZmF1bHQoKXtcbiAgICAgIGNvbnNvbGUubG9nKGEzKVxuICAgIH1cbiAgfVxufSlcbjwvc2NyaXB0PlxuXG48dGVtcGxhdGU+XG4gIDxoMT5IZWxsbzwvaDE+XG4gIDxzcGFuPnt7IGEgfX0gPC9zcGFuPlxuICA8c3Bhbj57eyBnIH19PC9zcGFuPlxuPC90ZW1wbGF0ZT5cbiIsImltcG9ydC1tYXAuanNvbiI6IntcbiAgXCJpbXBvcnRzXCI6IHtcbiAgICBcInZ1ZVwiOiBcImh0dHBzOi8vZGVwbG95LXByZXZpZXctNTc1Mi0tdnVlLXNmYy1wbGF5Z3JvdW5kLm5ldGxpZnkuYXBwL3Z1ZS5ydW50aW1lLmVzbS1icm93c2VyLmpzXCJcbiAgfVxufSJ9

yyx990803 pushed a commit that referenced this issue Mar 28, 2023
@sxzz
feat(complier-sfc): hoist literal constants for script (#5752)
7def8b1 
- Support using literal constants in macros
- fix useCssVars insert position edge case
- fix non-literal-const enum hoisting

close #5750
IAmSSH pushed a commit to IAmSSH/core that referenced this issue May 14, 2023
@sxzz @IAmSSH
feat(complier-sfc): hoist literal constants for script (vuejs#5752)
3f2e95a 
- Support using literal constants in macros
- fix useCssVars insert position edge case
- fix non-literal-const enum hoisting

close vuejs#5750
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
scope: script-setup ✨ feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(complier-sfc): add hoistStatic for <script setup>
2 participants
@LinusBorg @sxzz