Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming destructured props fails in some cases #5425

Closed
sqal opened this issue Feb 14, 2022 · 0 comments · Fixed by #5436
Closed

Renaming destructured props fails in some cases #5425

sqal opened this issue Feb 14, 2022 · 0 comments · Fixed by #5436
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. 🐞 bug Something isn't working scope: script-setup

Comments

@sqal
Copy link
Contributor

sqal commented Feb 14, 2022 •
edited
Loading

Version

3.2.31

Reproduction link

SFC Playground

Steps to reproduce

Just look at the compiled code in JS tab

What is expected?

"onUpdate:values": __props['onUpdate:values']

What is actually happening?

Reference to the renamed prop is not correct

"onUpdate:values": __props.undefined
@LinusBorg LinusBorg added 🐞 bug Something isn't working scope: script-setup labels Feb 14, 2022
@edison1105 edison1105 mentioned this issue Feb 16, 2022
Merged
@yyx990803 yyx990803 added the 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. label May 12, 2022
yyx990803 pushed a commit that referenced this issue May 13, 2022
@edison1105
fix(reactivity-transform): fix props access codegen for non-identifie…
242914d 
…r prop names (#5436)

fix #5425
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. 🐞 bug Something isn't working scope: script-setup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(compiler-sfc): sfc props transform aliasing w/ StringLiteral edison1105/vuejs-core
3 participants
@yyx990803 @LinusBorg @sqal