fix(shallowReactive): don't trigger watchers for oldVal === newVal #894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chearon
commented
Jan 25, 2022
src/reactivity/ref.ts
Outdated
| value.value = value.value | ||
| const v = value.value | ||
| value.value = !v | ||
| value.value = v |
There was a problem hiding this comment.
might need some advice here... this is not ideal for sync: true watchers, but I can't call ob.notify() without making bigger changes as the reference is not retrievable from value
antfu
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I found another situation that's causing me infinite loops with this library but not with Vue 3