Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(watch): watch will trigger when added new keys using set #468

Merged
merged 4 commits into from
Aug 10, 2020

Conversation

pikax
Copy link
Member

@pikax pikax commented Aug 7, 2020

fix #467

@antfu
Copy link
Member

antfu commented Aug 7, 2020

If I have recalled right, Vue 3 doesn't offer the set api. As the reactivity systems underneath are different, I think the set api is useful and necessary in some situations with Vue 2. Should we add a note in the readme to mention this difference?

@pikax
Copy link
Member Author

pikax commented Aug 7, 2020

set is only to circumvent the limitation on adding a new key limitation on vue2. In vue3 there's no such limitation when using proxys.

We should add it to the readme.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
README.md Outdated Show resolved Hide resolved
@antfu antfu merged commit 13bfed1 into vuejs:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

watch() with reactive() doesn't re-run when new properties are added to the reactive object
2 participants