Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type: Added Element type to ref BailTypes #278

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Conversation

kedrzu
Copy link
Contributor

@kedrzu kedrzu commented Mar 9, 2020

Suppose I want to return ref to the template to be filled with my html element:
const element = ref<HTMLElement>(null);

Then I wrap it with reactive:

const state = reactive({
    element,
    ...someOtherProps
})

Element goes through UnwrapRef and its type inference is broken.

@LinusBorg LinusBorg requested a review from ktsn March 11, 2020 14:32
@LinusBorg
Copy link
Member

@ktsn I think this makes sense, need a second opinion though.

Copy link
Member

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to me as well.

@haoqunjiang haoqunjiang merged commit 52e01d8 into vuejs:master Mar 12, 2020
pikax pushed a commit to pikax/vue-function-api that referenced this pull request Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants