fix: avoid accessing undeclared instance fields on type level #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktsn
commented
Nov 12, 2019
| type VueConstructorProxy<PropsOptions, RawBindings> = { | ||
| new (): ComponentRenderProxy< | ||
| type VueConstructorProxy<PropsOptions, RawBindings> = VueConstructor & { | ||
| new (...args: any[]): ComponentRenderProxy< |
There was a problem hiding this comment.
Modified this type as it cannot match existing typings which expects VueConstructor like vue-router. By writing argument as (...args: any[]), we can mix it with the intersected constructor so that ComponentRenderProxy retains even after inherit VueConstructor.
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-2.html
This probably fixes #185 ?
|
Does this get merged? |
|
This solves #185 for me! |
|
This PR can fix #185 for me. |
posva
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #187
As
neveris bottom type,ExtractPropTypes<never>is resolved as a type that accepts any field access:which is included in intersections of
ComponentRenderProxytype, consists ofVueProxyinstance type.The default type of
Propsseems to beunknown. As it is top type,ExtractPropTypes<unknown>will be{}which is expected type in this case.