Element-UI has grid system #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See http://element.eleme.io/#/en-US/component/layout, so I think it should not be in the "without layout system"
kazupon
requested changes
Apr 29, 2017
| @@ -785,7 +785,7 @@ Tooltips / popovers | |||
| - [vuetify](https://github.com/vuetifyjs/vuetify) - Material Component Framework for Vue.js 2. | |||
| - [muse-ui](https://github.com/museui/muse-ui) - Material Component library for Vue.js 2. | |||
| - [buefy](https://github.com/rafaelpimpa/buefy) - Components based on Bulma framework. | |||
|
|
|||
| - [element-ui](https://github.com/ElemeFE/element) - A Vue.js 2.0 UI Toolkit for Web. | |||
There was a problem hiding this comment.
so I think it should not be in the "without layout system"
Do not you contradictory? 🤔❓
There was a problem hiding this comment.
@kazupon : I dont think.
Element-UI is in the category : "Component Collections / Set of components without layout system : But Element-UI has a layout system.
So, 2 options :
- Change the name of the category
- Or move Element-UI to the category "Set of components + responsive layout system"
Anyway, that's not very important, but as me (new in VueJS) other people may not have look to Element-UI cause it's in the category "without layout system".
There was a problem hiding this comment.
sorry, I was mis-understood.
you're right.
kazupon
approved these changes
May 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See http://element.eleme.io/#/en-US/component/layout, so I think it should not be in the "without layout system"