v4: Fix useMutation "mutate" optional arguments #893
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a type error in
useMutation
's exportedmutate
function that required arguments to be specified, even though the intention was that they are optional.(This appears to have been caused by a typo - the first argument of
mutate
had a default value, but the second one didn't. I'm surprised that TypeScript didn't catch this.)This PR resolves one of several issues found while creating a graphql-code-generator plugin for vue-apollo hooks, which can be tracked here.