-
-
Notifications
You must be signed in to change notification settings - Fork 523
Typescript compilation error with latest apollo package #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
related with #577 |
Please merge this 😬 |
Merge and relase this please |
Tested @iharmanpannu's patch in an application where this was breaking and with the patch it works again. <3. |
Is there any reason why this hasn't been merged yet? ❤️ |
Me too waiting for this PR to be merged |
Merge and relase this please! This is a breaking thing. |
@Akryum Can u take this in consideration ? |
wish merge this pull request as soon as possible. can't wait to fix this bug. |
Hope this would be merged ASAP, thx a lot! |
@Akryum please merge and release this. |
types/options.d.ts
Outdated
@@ -47,7 +47,7 @@ export interface VueApolloQueryOptions<V, R> extends ExtendableVueApolloQueryOpt | |||
export interface VueApolloMutationOptions<V, R> extends MutationOptions<R> { | |||
mutation: DocumentNode; | |||
variables?: VariableFn<V>; | |||
optimisticResponse?: ((this: ApolloVueThisType<V>) => any) | Object; | |||
optimisticResponse?: ((this: ApolloVueThisType<V>) => any) | any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is much better to use strong types:
optimisticResponse?: ((this: ApolloVueThisType<V>) => R) | R
Thanks 👍 |
|
Fixed typescript compilation error