Serialize SSR against XSS #624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o client when exporting apollo states. Add jest for running unit tests. Add unit test for serialize functionality
|
@Akryum Any thoughts on merging and cutting a release? |
|
@Akryum bump, good to merge in? |
|
@Akryum Bump, do you need/want help managing prs in the repo? Happy to lend a hand if you are strapped for time. We use vue-apollo on a pretty large app and am familiar with internals and how it is used in ssr manually. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #158
We have been using serialize-javascript for this in production for a long time now (at least a year) on a pretty large usage of apollo and has been rock solid.