Skip to content

Catch up typings of dollar apollo #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 9, 2019

Conversation

joe-re
Copy link
Contributor

@joe-re joe-re commented Nov 17, 2018

update type definitions

fix: #409

Changes

  • add clients and defaultClient property to ApolloProvider
    • enable to use this.$apollo.provider.defaultClient by this
  • remove client property from DollerApollo
  • enable to specify client name to query
    • enable to specify client name when request query
// use `test` client to request
this.$apollo.query({ query: gql`query mockQuery { id }`, client: 'test' })

@joe-re joe-re changed the title Catch up typings dollar apollo Catch up typings of dollar apollo Nov 17, 2018
@matrunchyk
Copy link

Thank you for the package! Can this PR be merged?

@praveenpuglia
Copy link

Hi @thewunder , @Akryum - Any idea on when this will get merged? Eagerly waiting :)

BTW, we at work heavily rely on this and this has helped us continue with Vue in general so a Giant thanks 🙇

@Akryum Akryum merged commit 563c932 into vuejs:master Jan 9, 2019
@joe-re joe-re deleted the catch-up-typings-dollar-apollo branch January 9, 2019 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ApolloProvider typings not updated with properties defaultClient and clients.
5 participants