Skip to content

Fix error in renderless rendering #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2018
Merged

Fix error in renderless rendering #381

merged 1 commit into from
Sep 7, 2018

Conversation

mekhami
Copy link
Contributor

@mekhami mekhami commented Sep 3, 2018

this.$scopedSlots.default({}) returns an array of length one for the vNode, and the render function is expecting the vNode by itself. This fixes this bug in the current renderless functionality.

@mekhami
Copy link
Contributor Author

mekhami commented Sep 3, 2018

I can't fathom a use case where someone has multiple named scoped slots inside an but if that were the case I'm not sure the above would work. But I don't think that's supported in this component anyway.

@Akryum Akryum merged commit 799ac2b into vuejs:master Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants