Skip to content

Fix new SSR API #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 7, 2018
Merged

Fix new SSR API #379

merged 2 commits into from
Sep 7, 2018

Conversation

ciscorn
Copy link
Contributor

@ciscorn ciscorn commented Sep 1, 2018

Some fixes for the new SSR implementation:

  • The component resolver should accept camelCase and PascalCase names in options.components
  • no-prefetch is broken
  • prefetch: true is not documented but should be allowed for the backward compatibility
  • On making fake instances:
    • localData(vm)localData.call(vm, vm)
    • Inject computed properties, methods, $data, $props, etc.
    • Use Object.assign instead of spread properties (which may cause a syntax error in some environments such as the latest Nuxt)

@ciscorn ciscorn changed the title Fix new SSR helpers Fix new SSR API Sep 2, 2018
@Akryum
Copy link
Member

Akryum commented Sep 7, 2018

Awesome! Someone picking up my work while I'm on vacations! 😻
Thanks for your PR! 👍

@Akryum Akryum merged commit f83eb6a into vuejs:master Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants