Skip to content

[Untested] Remove lodash to reduce final size #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2018
Merged

Conversation

DeltaEvo
Copy link
Contributor

The size of vue-apollo was very big with lodash functions so I tried to get rid of them and see the file size after removal

Before

104K    dist/vue-apollo.esm.js
32K     dist/vue-apollo.min.js
108K    dist/vue-apollo.umd.js

After

52K     dist/vue-apollo.esm.js
24K     dist/vue-apollo.min.js
52K     dist/vue-apollo.umd.js

So 25%, not bad 😂

I don't know if that break something, throttle and debounce options seems undocumented, so the only case of breaking change is when someone was using lodash throttle and debounce options (leading, trailing, maxWait)

Tell me what do you think of removing lodash functions, so I'll try to see if my changes work

@Akryum Akryum merged commit fccb313 into vuejs:master May 21, 2018
@Akryum
Copy link
Member

Akryum commented May 21, 2018

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants