Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't redirect to html-suffix url for vercel #773

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

sxzz
Copy link
Contributor

@sxzz sxzz commented Oct 18, 2023

在创建 pull request 之前

仅针对于 Vercel,Netlify 无此问题

访问 https://cn.vuejs.org/api/application.html 将会跳转到没有 .html 的地址,然后再跳转回来(最新 VitePress 已取消此行为 vuejs/vitepress@ce8d139

本 PR 之后:不再跳转。不论添加 html 或不添加,内容皆一致。

请确认:

  • 我已经阅读过项目的 wiki 了解相关注意事项。
  • 我对翻译内容的改动不包含基于英文原版的扩展、删减或演绎 (如有,请移步至英文文档仓库讨论,相关结论会被定期从英文版同步)

问题描述

@vercel
Copy link

vercel bot commented Oct 18, 2023

@sxzz is attempting to deploy a commit to the vuejs Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cn-vuejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 7:28pm

@sxzz
Copy link
Contributor Author

sxzz commented Oct 18, 2023

P.S 本项目是否还需要 Netlify 部署?如不需可以考虑删除,避免迷惑
/cc @ShenQingchuan @Jinjiang

@sxzz sxzz changed the title fix: don't redirect to html-suffix url fix: don't redirect to html-suffix url for vercel Oct 18, 2023
@Jinjiang
Copy link
Member

Netlify 的配置应该是从英文版代码同步过来的,感觉也可以在 README 里简单注明一下,因为免不了英文版配置有更新将来同步的时候还是要反复处理

@sxzz
Copy link
Contributor Author

sxzz commented Oct 23, 2023

英文文档没有跑在 Vercel 上面,没有 vercel.json 文件🤔

Netlify 无此问题

@Jinjiang Jinjiang merged commit d96dec8 into vuejs-translations:main Oct 23, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants