Skip to content

Fix missing dependency bumps #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 16, 2017
Merged

Fix missing dependency bumps #987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
05148da
switch hello-world tag to PascalCase (#951)
hootlex Oct 9, 2017
9937176
fix Es6 code issue.
LinusBorg Oct 11, 2017
52a069c
Fix bug in dev-server when a proxyTable entry is a string (#965)
schettino72 Oct 11, 2017
9befbfc
Fix casing
LinusBorg Oct 14, 2017
b6a4694
Revert 9befbfc
LinusBorg Oct 14, 2017
1a24741
update to vue and vue-router latest version (#984)
Ffloriel Oct 16, 2017
7cddb21
fix missing dependency updates for
LinusBorg Oct 16, 2017
476a6b8
bump version string
LinusBorg Oct 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion template/build/dev-client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* eslint-disable */
'use strict'
require('eventsource-polyfill')
const hotClient = require('webpack-hot-middleware/client?noInfo=true&reload=true')
var hotClient = require('webpack-hot-middleware/client?noInfo=true&reload=true')
Copy link
Contributor

@aladdin-add aladdin-add Oct 16, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why using var? it's in strict mode, using const is fine, and recommended! @LinusBorg

Copy link
Contributor Author

@LinusBorg LinusBorg Oct 16, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this piece of code is injected into the client bundle in dev mode and not transpiled - which means it breaks in older browsers.


hotClient.subscribe(function (event) {
if (event.action === 'reload') {
Expand Down
2 changes: 1 addition & 1 deletion template/build/dev-server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ app.use(hotMiddleware)

// proxy api requests
Object.keys(proxyTable).forEach(function (context) {
const options = proxyTable[context]
let options = proxyTable[context]
if (typeof options === 'string') {
options = { target: options }
}
Expand Down
2 changes: 1 addition & 1 deletion template/config/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
'use strict'
// Template version: 1.1.1
// Template version: 1.1.3
// see http://vuejs-templates.github.io/webpack for documentation.

const path = require('path')
Expand Down
8 changes: 4 additions & 4 deletions template/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"lint": "eslint --ext .js,.vue src{{#unit}} test/unit/specs{{/unit}}{{#e2e}} test/e2e/specs{{/e2e}}"{{/lint}}
},
"dependencies": {
"vue": "^2.4.2"{{#router}},
"vue-router": "^2.7.0"{{/router}}
"vue": "^2.5.2"{{#router}},
"vue-router": "^3.0.1"{{/router}}
},
"devDependencies": {
"autoprefixer": "^7.1.2",
Expand Down Expand Up @@ -90,9 +90,9 @@
"ora": "^1.2.0",
"rimraf": "^2.6.0",
"url-loader": "^0.5.8",
"vue-loader": "^13.0.4",
"vue-loader": "^13.3.0",
"vue-style-loader": "^3.0.1",
"vue-template-compiler": "^2.4.2",
"vue-template-compiler": "^2.5.2",
"portfinder": "^1.0.13",
"webpack": "^3.6.0",
"webpack-dev-middleware": "^1.12.0",
Expand Down
2 changes: 1 addition & 1 deletion template/src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
{{#router}}
<router-view/>
{{else}}
<hello-world/>
<HelloWorld/>
{{/router}}
</div>
</template>
Expand Down