FIX: can't resolve json files #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzhjerry
changed the title
LinusBorg
suggested changes
Dec 14, 2016
| @@ -20,7 +20,7 @@ module.exports = { | |||
| filename: '[name].js' | |||
| }, | |||
| resolve: { | |||
| extensions: ['', '.js', '.vue'], | |||
| extensions: ['', '.js', '.json', '.vue'], | |||
There was a problem hiding this comment.
I think we should priorize .vue over .json, wouldn't you agree?
There was a problem hiding this comment.
sure, will make the modification right away
LinusBorg
approved these changes
Dec 14, 2016
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I installed Airtable's npm package and noticed it's using implicit
requirecallrequire('./internal_config')whereinternal_configis a JSON file. So when I was using this package, webpack was throwing me errors since.jsonis not a resolvable extension in the config.I believe this could also happen when other people use other 3rd party packages so I made this patch to fix it.
The implicit require call in Airtable: (https://github.com/Airtable/airtable.js/blob/454f4b3d952ec8f717bcfce841f3937f50bddea0/lib/run_action_with_jquery.js#L4)