Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve eslint warnings; use webpack alias. #399

Merged
merged 3 commits into from
Dec 14, 2016
Merged

Solve eslint warnings; use webpack alias. #399

merged 3 commits into from
Dec 14, 2016

Conversation

myst729
Copy link
Contributor

@myst729 myst729 commented Dec 6, 2016

  • Solve eslint warnings for double quotes in nightwatch config file.
  • Use webpack alias src over relative path in unit test entry file.

@LinusBorg
Copy link
Contributor

removing double quotes is fine, but why add quotes to keys that don't need any? which eslint rule/preset does require this?

@myst729
Copy link
Contributor Author

myst729 commented Dec 14, 2016

Oops, my bad. It was a batch find-replace, updated to keep only necessary quotes.

@LinusBorg LinusBorg mentioned this pull request Dec 14, 2016
Closed
@LinusBorg
Copy link
Contributor

Thanks!

@LinusBorg LinusBorg merged commit bf68340 into vuejs-templates:master Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@myst729 @LinusBorg