Lighthouse best practices audit: short_name #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should inform the user about the Lighthouse recommendation of Best Practices, rather than implicitly applying the "name" as "short_name". > Manifest's short_name Won't Be Truncated When Displayed on Homescreen ([Lighthouse](https://developers.google.com/web/tools/lighthouse/audits/manifest-short_name-is-not-truncated))
addyosmani
approved these changes
Aug 4, 2017
frandiox
pushed a commit
to OnsenUI/vue-pwa-webpack
that referenced
this pull request
Oct 13, 2017
Should inform the user about the Lighthouse recommendation of Best Practices, rather than implicitly applying the "name" as "short_name". > Manifest's short_name Won't Be Truncated When Displayed on Homescreen ([Lighthouse](https://developers.google.com/web/tools/lighthouse/audits/manifest-short_name-is-not-truncated))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should inform the user about the Lighthouse recommendation of Best Practices, rather than implicitly applying the "name" as "short_name".