Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [修复自定义按钮无渲染] #7628

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

trry-hub
Copy link
Contributor

@trry-hub trry-hub commented Jun 5, 2024

Tour component TourStep custom button properties, no rendering of the passed parameter children

Tour 组件 TourStep 自定义按钮属性,没有渲染传入的参数 children

@@ -119,7 +119,7 @@ const panelRender = defineComponent({
size="small"
class={classNames(`${prefixCls}-prev-btn`, prevButtonProps?.className)}
>
{prevButtonProps?.children ?? contextLocale.Previous}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

要判断下是否是 函数了,毕竟文档里写的是 children 是 vnode类型

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我增加了isFunction判断,看现在代码可否

@tangjinzhou tangjinzhou merged commit 4b7c6ac into vueComponent:main Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants