Skip to content

feat(menu): icon support function components with items and update demo #6457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 23, 2023
Merged

feat(menu): icon support function components with items and update demo #6457

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4cdf4d8
fix(menu): icon do not show problem
CCherry07 Apr 13, 2023
3ff733a
fix(menu): icon do not show problem
CCherry07 Apr 13, 2023
6d5aa79
feat(menu): update demo
CCherry07 Apr 13, 2023
91c375e
test(menu): update demo snap
CCherry07 Apr 13, 2023
213a17b
chore(Menu): update docs
CCherry07 Apr 23, 2023
b5152ee
test(Menu): update demo
CCherry07 Apr 23, 2023
89dc6ff
Update MenuItem.tsx
tangjinzhou Apr 23, 2023
b0fe812
Update SubMenu.tsx
tangjinzhou Apr 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update SubMenu.tsx
  • Loading branch information
@tangjinzhou
tangjinzhou authored Apr 23, 2023
commit b0fe8121ec25bc65e731e065615cece47c5284e5
2 changes: 1 addition & 1 deletion components/menu/src/SubMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ export default defineComponent({
return (
<>
{cloneElement(
typeof icon === 'function' ? <icon /> : icon,
typeof icon === 'function' ? icon() : icon,
{
class: `${prefixCls.value}-item-icon`,
},
Expand Down