Default fill to false on Polylines #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@bytesnz the fill comes from the Path mixin, and there should be se to false, can you fix the PR ? |
Contributor
Author
|
Sorry for the delay. Have updated the mixins to follow Leaflet and have updated the mixins docs |
Contributor
|
@bytesnz Thank you! merging |
|
will there be a v1.2.4 with this fix? |
Contributor
|
@jarlehal no a 1.2.4 but 2.0.0-beta.1 I am going to release it in the next few min |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Polylines have a fill when not given any parameters as seen on https://korigan.github.io/Vue2Leaflet/examples > Geometry. It should default to no fill