Mouse movement, particularly, needs to be debounced

[disarticulate]

I'd debounce as much as possible, maybe segregate. But vue crashes development mode with sub ms events.

[KoRiGaN]

Hi @disarticulate,

Thanks for your pull request.
This should be done in your own application. Vue2Leaflet is just a wrapper of Leaflet and I don't want to debounce event with some fixed rate.

I'm closing this request as it will modify Leaflet behaviour and limit potential usages.

Micka

[disarticulate]

How would you propose to debounce the event, as it's triggering inside your component? ie, Vue devtools records the event regardless of any listener I attach, crashing devtools eventually.

…

On Tue, Mar 27, 2018, 8:48 AM Mickaël ***@***.***> wrote: Hi @disarticulate <https://github.com/disarticulate>, Thanks for your pull request. This should be done in your own application. Vue2Leaflet is just a wrapper of Leaflet and I don't want to debounce event with some fixed rate. I'm closing this request as it will modify Leaflet behaviour and limit potential usages. Micka — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#135 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQp7PfQUn4_7RHsBTStsNXlBG9Varc7Oks5tikNGgaJpZM4SjnW0> .

[KoRiGaN]

Event handling have been simplified from v1.0.0 and nothing happens in Vue2Leaflet.

So if you do not set any event handler nothing should happens.
If you set an event handler just set an debounced one.

Micka

[disarticulate]

As I said, devtools for Vue does, and crashes.

…

On Tue, Mar 27, 2018, 10:29 AM Mickaël ***@***.***> wrote: Event handling have been simplified from v1.0.0 and nothing happens in Vue2Leaflet. So if you do not set any event handler nothing should happens. If you set an event handler just set an debounced one. Micka — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#135 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQp7PeBfbHsR_B15cdtLg4JLljLJcWFVks5tilrLgaJpZM4SjnW0> .

[KoRiGaN]

Do you have an example/list of step that make devtools crash ?

It doesn't crash on my side.

[disarticulate]

Open, move mouse recording events. L-mousemove event floods the screen. Vue 2.5.16, Vue devtools v4.1.4 Maybe it's an upstream issue, but maybe you can consider whether you actually need subms response as default. On Mar 27, 2018 11:10 AM, "Mickaël" <notifications@github.com> wrote: Do you have an example/list of step that make devtools crash ? It doesn't crash on my side. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#135 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQp7PRMGM1iLT8nn37Gcf8cUz20jo9LHks5timR5gaJpZM4SjnW0> .

[KoRiGaN]

Please give Vue2Leaflet v1.0.1 a try first.

I'm pretty sure it fixes your issue.

[disarticulate]

Ok.

…

On Tue, Mar 27, 2018, 11:45 AM Mickaël ***@***.***> wrote: Please give Vue2Leaflet v1.0.1 a try first. I'm pretty sure it fixes your issue. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#135 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQp7PT50ZdKHtfR2R9oT9VATseUkhTR7ks5timy9gaJpZM4SjnW0> .