-
-
Notifications
You must be signed in to change notification settings - Fork 12
feat: add option 'allowConsoleClears' #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option 'allowConsoleClears' #30
Conversation
resetLastNotification() | ||
if (options.allowConsoleClears) { | ||
console.clear() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure exactly what resetLastNotification
does. Not sure if it makes more sense for it to be inside the if (options.allowConsoleClears)
block or not?
Thanks @darrinmn9 I will test this week to approve. |
@ktquez i know your busy, just wanted to give you a bump on this ;). Let me know if you have a response to my other comment or if you'd like me to modify the naming/approach in any way. |
Hi @darrinmn9, sorry for the delay in answering you. I actually had time to test it yesterday, I saw that it works, but having a global clear and a clear for updated I think it will be a little confusing. I think adding a beforeDestroy () {
clear(false, options)
} With that, we would put in the documentation that the option I have been working on a way to avoid the browser console and show errors using a more user friendly component. |
ok, so your saying lets close this PR and wait till you arrive at a better solution in Aug? I do agree having 2 console related |
Until v3 becomes available, this PR works and can help at the moment anyone who needs this functionality. |
@darrinmn9 |
Which problem does this PR solve?
#28
When developing locally, developers sometimes utilize the console for helpful debug info.
vue-axe
should respect if developers don't want the console cleared.No breaking changes since
allowConsoleClears
defaults totrue
.Let me know if you prefer a different name for
allowConsoleClears
.