Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macro): Allow macro to be dragged to hotbar for 1.8.x #347

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

bakbakbakbakbak
Copy link
Collaborator

Macros were not permitted to be dragged to the hotbar as it was restricted to creating item macros. This fixes that behaviour.

Also adds a notification (with localization) that properly warns that the user tries to create a macro from a non-item if that is the case.

@bakbakbakbakbak bakbakbakbakbak changed the title fix(macro): Allow macro to be dragged to hotbar fix(macro): Allow macro to be dragged to hotbar for 1.8.x Feb 11, 2023
Copy link
Member

@anthonyronda anthonyronda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, LGTM

@anthonyronda anthonyronda merged commit fba14d3 into vttred:1.8.x Feb 28, 2023
@bakbakbakbakbak bakbakbakbakbak deleted the fix/macro_to_hotbar branch March 1, 2023 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants